Skip to content

[DowngradePhp84] Add DowngradeArrayAllRector #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 7 commits into from
Jul 11, 2025
Merged

[DowngradePhp84] Add DowngradeArrayAllRector #290

samsonasik merged 7 commits into from
Jul 11, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 11, 2025 •
edited
Loading

@samsonasik
Copy link
Member Author

samsonasik commented Jul 11, 2025

implemented 🎉 /cc @xHeaven

@samsonasik samsonasik closed this Jul 11, 2025
@samsonasik samsonasik reopened this Jul 11, 2025
@samsonasik
Copy link
Member Author

samsonasik commented Jul 11, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 6fae74e into main Jul 11, 2025
6 checks passed
@samsonasik samsonasik deleted the add-downgrade-array-all branch July 11, 2025 07:07
@samsonasik
Copy link
Member Author

samsonasik commented Jul 13, 2025

@xHeaven the current functionality is only on assign expression -> foreach as it only mirror of the upgrade rule which apply foreach -> assign expression:

it doesn't accomodate on other statement, eg: return, if condition, etc. It may need to use ExprInTopStmtMatcher service, so it can prepend before the target statement

rector-downgrade-php/rules/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector.php

Lines 92 to 101 in 31b8bde

$exprArrayKeyFirst = $this->exprInTopStmtMatcher->match(
$node,
function (Node $subNode): bool {
if (! $subNode instanceof FuncCall) {
return false;
}
return $this->isName($subNode, 'array_key_first');
}
);

that can be next improvement when we have a use case later ;)

@samsonasik samsonasik mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @actions-user